Skip to content

fix(spec): add kalshi key_type ed25519/rsa to GenerateApiKeyRequest - #2635

Open
ibrhmyi wants to merge 1 commit into
pmxt-dev:mainfrom
ibrhmyi:contributor/issue-2446-49c634b695
Open

ibrhmyi wants to merge 1 commit into
pmxt-dev:mainfrom
ibrhmyi:contributor/issue-2446-49c634b695

Conversation

@ibrhmyi

@ibrhmyi ibrhmyi commented Oct 31, 2026

Copy link
Copy Markdown

Closes #2446.

Kalshi added an optional key_type field ("ed25519" | "rsa") to POST /api_keys/generate (changelog, 2026-09-24). The cached spec (core/specs/kalshi/Kalshi.yaml v3.7.0) only models RSA key generation, so spec-generated clients cannot request Ed25519 keys.

Change

  • GenerateApiKeyRequest gains an optional key_type: string with enum: [ed25519, rsa] and a description citing the changelog date — matching the file's inline-enum style; not added to required (additive per the drift report)
  • No default asserted: secondary sources conflict on the omit-behavior, so the spec stays silent rather than inventing drift

Verification

  • Premise checked before editing: key_type/ed25519 absent from the schema (grep), and the field confirmed against three independent API references
  • Strict YAML parse (js-yaml via the repo's bun) confirms the schema path, type, exact enum, optionality, and that name remains required

AI assistance was used for this contribution (implementation and review).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec drift: kalshi — Ed25519 key type added to POST /api_keys/generate; not in spec

1 participant