Skip to content

Prevent server from crashing with SIGPIPE when terminating client - #46

Merged
guruofquality merged 2 commits into
pothosware:masterfrom
daniel-sch:sigpipe_fix
Aug 22, 2018
Merged

guruofquality merged 2 commits into
pothosware:masterfrom
daniel-sch:sigpipe_fix

Conversation

@daniel-sch

Copy link
Copy Markdown
Contributor

Fixes #45

@guruofquality

Copy link
Copy Markdown
Contributor

I guess its fine to always specify the MSG_NOSIGNAL, its not like we need the sigpipe.

But the fix isnt portable for OSX and windows. Can you add an ifdef to https://github.com/pothosware/SoapyRemote/blob/master/common/SoapySocketDefs.in.hpp

/***********************************************************************
 * socket flag definitions
 **********************************************************************/
#ifndef MSG_NOSIGNAL
#define MSG_NOSIGNAL 0
#endif 

@guruofquality
guruofquality changed the base branch from master to maint August 20, 2018 17:37
@guruofquality
guruofquality changed the base branch from maint to master August 20, 2018 17:37
@daniel-sch

Copy link
Copy Markdown
Contributor Author

Thank you for your feedback, I added the workaround you proposed.

@guruofquality
guruofquality merged commit 6efb692 into pothosware:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants