Skip to content

feat: add shell-hook command - #672

Merged
wolfv merged 8 commits into
prefix-dev:mainfrom
orhun:feat/add_shell_hook
Jan 17, 2024
Merged

wolfv merged 8 commits into
prefix-dev:mainfrom
orhun:feat/add_shell_hook

Conversation

@orhun

@orhun orhun commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

closes #410

This is a hidden command - let me know where should we document this!

@orhun

orhun commented Jan 16, 2024

Copy link
Copy Markdown
Contributor Author

Hmm, I'm think we can also add tests for this if needed.

@ruben-arts

Copy link
Copy Markdown
Contributor

A test would be much appreciated! I'm not sure we need to hide it from the help.

@wolfv

wolfv commented Jan 16, 2024

Copy link
Copy Markdown
Member

Looks good!

@orhun

orhun commented Jan 16, 2024

Copy link
Copy Markdown
Contributor Author

A test would be much appreciated!

Added in 5c65ccf

I'm not sure we need to hide it from the help.

Added about text in b86a979 in case we decide to make it visible in the future.

@ruben-arts

Copy link
Copy Markdown
Contributor

He it would be awesome to have this added to the examples/docker-build project.

Here it would be nice to install something from a pixi.toml (pixi itself might be a weird example).
Then write the pixi shell-hook > pixi-activation.sh.
Then throw away the initial install image and only copy the .sh file and the environment to be able to activate it in the docker image without having pixi in the docker image.

I guess you can use docker multistage for this

Comment thread src/cli/shell_hook.rs Resolved
@wolfv

wolfv commented Jan 17, 2024

Copy link
Copy Markdown
Member

I think we also need to get rid of the shebang because that wouldn't work on a powershlel script on Linux etc

@orhun

orhun commented Jan 17, 2024

Copy link
Copy Markdown
Contributor Author

Removed shebang in 9591a1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement shell-hook

4 participants