Skip to content

Incorrect handling of tabs in message value #173

Closed

Description

@eemeli

As identified in mozilla/pontoon#2470 (comment), this happens:

from fluent.syntax import ast, FluentParser, FluentSerializer
parser = FluentParser()
serializer = FluentSerializer()

string = """places-open-in-container-tab =
    .label = Բացել նոր ներդիրում
    .accesskey =	
"""

string
'places-open-in-container-tab =\n    .label = Բացել նոր ներդիրում\n    .accesskey = \t\n'

serializer.serialize(parser.parse(string))
'places-open-in-container-tab =\n    .label = Բացել նոր ներդիրում\n    .accesskey = \n'

Tabs should not be lost; they count as valid inline_text characters according to the spec.

Activity

  1. Pike commented on Apr 23, 2022

    @Pike
    Contributor

    Probably also a bug in js syntax parser, and the runtime parser.

  2. eemeli commented on Apr 23, 2022

    @eemeli
    MemberAuthor

    Yeah, will need to check all the implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions