Repository navigation
Re-vendor GOVERNANCE.md's Verbatim Sections From the Hub - #482
Merged
Merged
Conversation
This was referenced Nov 9, 2026
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Owner
Author
|
A recorded local strict-review pass covers head |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #482 +/- ##
========================================
Coverage 87.68% 87.68%
========================================
Files 11 11
Lines 1941 1941
Branches 252 252
========================================
Hits 1702 1702
Misses 166 166
Partials 73 73 🚀 New features to boost your workflow:
|
ptr727
added a commit
that referenced
this pull request
Nov 9, 2026
…m the Hub (#480) Part c of 4 of the hub resync at hub `main` `c175d557` (`audit run 2026-11-09T16:23:53Z | hub c175d557 | branch override develop`). It replaces #475, which the maintainer chose to split. That PR's Copilot round read 32 of its 50 files and stopped at about 1,840 changed lines, so each part here stays at or below that size. The four parts are #478, #479, #480 and #481. Every file here is byte-identical to the content #475's head (`c1193c97`) carried. The skills tree and the whole-file docs are byte-identical to the hub. The `AGENTS.md`/`GOVERNANCE.md` verbatim sections were written by the hub's `scripts/carry.py`. See #475 for the probes run before overwriting and for how the hand-merged files were judged. Files: `AGENTS.md`, `AUDIT.md`, `CODESTYLE.md`, `.github/skills/local-strict-review/SKILL.md`, `.github/skills/python-codestyle/SKILL.md`, `.github/skills/repo-worktree/SKILL.md`, `.github/skills/skill-lifecycle/SKILL.md`, `.github/skills/workflow-ci-contract/references/d-guarantees.md`. Copilot's first round on this pull request left `GOVERNANCE.md`, `WORKFLOW.md` and `agent-conduct/SKILL.md` out of its file table. Those three now travel alone in #482, #483 and #484. A second local pass over this reduced head recorded 0 findings. ## Findings left open by the local review The local strict review recorded the findings below. Each is a reference into a file another part carries, so it lasts only while this part sits on `develop` alone. On the combined tree of all four parts, every reference resolves. The four parts merge into `develop` back to back, with no release dispatched in between, so no released state carries a dangling reference. - `introduced`, transient: AGENTS.md:135 - routes no-maintainer runs to `backlog-burndown`'s away mode and the question queue to `decision-triage`, and no longer lists `unattended-handoff`. On this branch `.github/skills/decision-triage/` is absent, and the develop-version `backlog-burndown/SKILL.md:15-17` has no away mode and redirects to `unattended-handoff`, which the routing table dropped. So an agent asked to run unattended is routed to a mode that does not exist, and is redirected to a skill the entry point no longer names. Transient until a, b and d merge. - `introduced`, transient: .github/skills/local-strict-review/SKILL.md:152 - cites `pr-review-conduct` "Every finding ends in a listed outcome" (also :167), but this branch's develop-version pr-review-conduct still has "Every finding ends in one of five outcomes". :156 owes another round while a `pre-existing` finding "that outcome 4 fixes here" is open, but that pr-review-conduct's outcome 4 is "file the issue first", which never fixes here. So the round-closing test cannot be applied as written. Transient until a merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added a commit
that referenced
this pull request
Nov 9, 2026
Part f of the hub resync at hub `main` `c175d557` (`audit run 2026-11-09T16:23:53Z | hub c175d557 | branch override develop`). It was split out of #480 because Copilot's round on that head left `GOVERNANCE.md`, `WORKFLOW.md` and `agent-conduct/SKILL.md` out of its file table. This single-file pull request carries `WORKFLOW.md` byte-identical to #475's head (`c1193c97`) and to the hub. The other parts are #478, #479 and #481 (merged), #480, and the sibling single-file parts #482 to #484. ## Findings left open by the local review - `introduced`, resolved by #476: WORKFLOW.md:192 - D7.1 now requires the publisher's group to be ref-scoped `${{ github.workflow }}-${{ github.ref }}` with github.run_id appended on a push the plan does not publish, but develop's .github/workflows/publish-release.yml:30-31 still uses `group: ${{ github.workflow }}`, so after this merges a develop push that publishes nothing can replace a pending main publish in the shared group and the repo audits not operational on D7.1; the fix lives on resync/workflows-2026-11-09, which is not among the recorded parts (#478, #479, #481), so it stays broken unless that branch lands too - `introduced`, resolved by #476: WORKFLOW.md:145 - D1.5 now requires a workflow other events also trigger to yield the ruleset-bound aggregator name only when github.event_name == 'pull_request', but develop's .github/workflows/test-pull-request.yml:97 names the job `Check pull request workflow status job` statically while the workflow also runs on push (lines 14-15) and workflow_dispatch (line 16), so a dispatch on a PR head posts the required context without the PR run's gates; same dependency on resync/workflows-2026-11-09 as above 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added a commit
that referenced
this pull request
Nov 9, 2026
Part g of the hub resync at hub `main` `c175d557` (`audit run 2026-11-09T16:23:53Z | hub c175d557 | branch override develop`). It was split out of #480 because Copilot's round on that head left `GOVERNANCE.md`, `WORKFLOW.md` and `agent-conduct/SKILL.md` out of its file table. This single-file pull request carries `.github/skills/agent-conduct/SKILL.md` byte-identical to #475's head (`c1193c97`) and to the hub. The other parts are #478, #479 and #481 (merged), #480, and the sibling single-file parts #482 to #484. ## Findings left open by the local review None. The local strict review recorded 0 findings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added a commit
that referenced
this pull request
Nov 9, 2026
…#476) Fixes the two workflow interface findings from the hub resync audit (`audit run 2026-11-09T16:23:53Z | hub c175d557 | branch override develop`). This is the second of three pull requests for this cycle. **Merge after #482 and #483.** #475 was split, and those two parts carry the hub's current `GOVERNANCE.md` "Workflow YAML Conventions" and `WORKFLOW.md` D1.5/D7.1. Until it lands, this repository's carried copies still describe the publisher's old ref-independent group, which is the rule this branch replaces. Each local review pass recorded one finding, and it was always this ordering dependency. ## Changes - `publish-release.yml`: the concurrency group becomes the ref-scoped publisher group that `WORKFLOW.md` D7.1 requires (Concurrency exception 2). It takes a `github.run_id` suffix for a push the plan does not publish. The new group matches the hub's `catalog/snippets/workflows/publish-release.yml` byte for byte. Its actor allowlist matches `publish-plan-task.yml` at the pinned `7cfe988`. - `test-pull-request.yml`: the aggregator's `name:` is now an expression, per D1.5. Only a `pull_request` run posts the ruleset-bound context `Check pull request workflow status job`. A push or dispatch run on `main`/`develop` posts `Check workflow status job`, so it cannot satisfy the required check on a pull request's head. Nothing else in the repository consumes the check name. - `merge-bot-pull-request.yml` and `run-periodic-codegen-pull-request.yml` (`f2e075e`): the prose concurrency comments become `GOVERNANCE.md "Workflow YAML Conventions" Concurrency exception (1)` and `(5)`. The hub's Concurrency bullet has each exception cited by number, never restated. Both now match the hub's catalog snippets byte for byte. A local review of #482 found this sibling, and the sweep found no other workflow out of line. ## Verification - actionlint: pass. - Local strict review (agent-skill, recorded): 1 finding, the ordering dependency on #475 described above. - The workflow comments are new comment lines, so this PR carries the `comments` label. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part e of the hub resync at hub
mainc175d557(audit run 2026-11-09T16:23:53Z | hub c175d557 | branch override develop). It was split out of #480 because Copilot's round on that head leftGOVERNANCE.md,WORKFLOW.mdandagent-conduct/SKILL.mdout of its file table. This single-file pull request carriesGOVERNANCE.mdbyte-identical to #475's head (c1193c97) and to the hub. The other parts are #478, #479 and #481 (merged), #480, and the sibling single-file parts #482 to #484.Findings left open by the local review
introduced, resolved by Scope the Publisher Group to Its Ref and Name the Aggregator by Event #476: GOVERNANCE.md:271 - the Concurrency bullet now requires each documented exception to be "cited by number, never restated, in the comment above its implementing workflow's concurrency: key", but develop's .github/workflows/merge-bot-pull-request.yml:9-10 (exception 1) and .github/workflows/run-periodic-codegen-pull-request.yml:13-14 (exception 5) restate their rationale and cite no number, and resync/workflows-2026-11-09 fixes only publish-release.yml, so once every part merges a WORKFLOW.md 5A audit of the D9/Workflow YAML Conventions style rules still records both workflows as violating; fix in a workflow change by replacing each comment with# GOVERNANCE.md "Workflow YAML Conventions" Concurrency exception (1)/(5)as the hub's catalog/snippets/workflows copies do🤖 Generated with Claude Code