Repository navigation
Pluralize the Audit's Extra-Caller Finding for Several Jobs - #1944
Conversation
The finding named every non-validate job calling validate-task.yml in singular grammar, so a list of two read as naming only the last. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a localized message-only adjustment with no apparent impact on audit behavior.
Review effort: Lite
Findings: None
What changed in this PR
Updates the audit's python-directories DRIFT message in spec/audit.py to use correct singular/plural wording when multiple non-validate jobs call validate-task.yml, improving clarity of the audit output without changing audit logic.
Changes:
- Adjust DRIFT message to say "from job X" vs "from jobs X, Y" based on the number of callers.
- Reword the trailing clause to more directly state that only the
validatejob'spython-directoriesinput is compared against the registry.
| File | Description |
|---|---|
| spec/audit.py | Refines the audit DRIFT message for pluralization and clearer wording when extra calling jobs are detected. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1944 +/- ##
========================================
Coverage 55.36% 55.36%
========================================
Files 16 16
Lines 7216 7216
========================================
Hits 3995 3995
Misses 3221 3221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Fixes the grammar finding Copilot raised on promotion PR #1943. When several non-
validatejobs call validate-task.yml, the audit's DRIFT message used singular wording ("from job a, b, whose ..."). It now says "from job X" for one and "from jobs X, Y" for several, followed by "and only the job keyed 'validate' has its python-directories input compared against the registry."Test plan
spec/audit.py --selftestpasses.🤖 Generated with Claude Code