Skip to content

Pluralize the Audit's Extra-Caller Finding for Several Jobs - #1944

Merged
ptr727 merged 1 commit into
developfrom
feature/caller-finding-plural
Sep 27, 2026
Merged

ptr727 merged 1 commit into
developfrom
feature/caller-finding-plural

Conversation

@ptr727

@ptr727 ptr727 commented Sep 27, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the grammar finding Copilot raised on promotion PR #1943. When several non-validate jobs call validate-task.yml, the audit's DRIFT message used singular wording ("from job a, b, whose ..."). It now says "from job X" for one and "from jobs X, Y" for several, followed by "and only the job keyed 'validate' has its python-directories input compared against the registry."

Test plan

  • spec/audit.py --selftest passes.
  • The message was printed for a two-job caller and reads correctly.
  • A local strict review found nothing.

🤖 Generated with Claude Code

The finding named every non-validate job calling validate-task.yml in singular grammar, so a list of two read as naming only the last.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 27, 2026 23:41
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: aee03a96-e1e0-4df2-9aba-c162bb81bd2f


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is a localized message-only adjustment with no apparent impact on audit behavior.

Review effort: Lite
Findings: None

What changed in this PR

Updates the audit's python-directories DRIFT message in spec/audit.py to use correct singular/plural wording when multiple non-validate jobs call validate-task.yml, improving clarity of the audit output without changing audit logic.

Changes:

  • Adjust DRIFT message to say "from job X" vs "from jobs X, Y" based on the number of callers.
  • Reword the trailing clause to more directly state that only the validate job's python-directories input is compared against the registry.
File Description
spec/​audit.py Refines the audit DRIFT message for pluralization and clearer wording when extra calling jobs are detected.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Sep 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.36%. Comparing base (cae0c12) to head (fe280d3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1944   +/-   ##
========================================
  Coverage    55.36%   55.36%           
========================================
  Files           16       16           
  Lines         7216     7216           
========================================
  Hits          3995     3995           
  Misses        3221     3221           
Flag Coverage Δ
python-3.13 55.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 29a9690 into develop Sep 27, 2026
11 checks passed
@ptr727
ptr727 deleted the feature/caller-finding-plural branch September 27, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants