Repository navigation
Avoid AttributeError when printing asynchronous Promises - #1095
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing a
Promisecurrently callsResult.__str__, which reads result attributes such asexitedthat the promise does not expose. GivePromisea command-only string representation that neither waits for completion nor invents an exit status. The two new regression tests fail on the base commit.Fixes #996. This targets the 2.2 release line in accordance with the contribution guide's bugfix branching policy. Validation: 187 runner/result/promise tests pass, with 3 skips, on WSL Linux/Python 3.14.4 using a real PTY and disabled pytest capture. Real asynchronous-command smoke checks reproduce the original error and verify the fix on Windows/Python 3.12.3 and Linux/Python 3.14.4. Black 22.8 (79 columns), pycodestyle 2.8, pyflakes 2.4 and mypy 0.971 (Linux/Python 3.9 static target) pass. The pinned Flake8 4 launcher is incompatible with this host's importlib metadata API, so its core style/static components were run directly. The complete project and older-interpreter CI matrix were not run.