Skip to content

fix Remove duplicate diagnostic mode setting - #5686

Open
asukaminato0721 wants to merge 1 commit into
pyrefly-org:mainfrom
asukaminato0721:cleanup-diagnostic-mode
Open

asukaminato0721 wants to merge 1 commit into
pyrefly-org:mainfrom
asukaminato0721:cleanup-diagnostic-mode

Conversation

@asukaminato0721

Copy link
Copy Markdown
Collaborator

Summary

Fixes #5446 (comment)

Expose diagnostic scope once in the VS Code settings UI. Keep the server's legacy pyrefly key and its precedence so existing client settings remain effective.

  • I am a human, and I fully understand the code I am submitting.

Test Plan

add test

Expose diagnostic scope once in the VS Code settings UI. Keep the server's legacy pyrefly key and its precedence so existing client settings remain effective.
@github-actions

Copy link
Copy Markdown

✅ This PR meets all requirements from our pull request checklist.

Optional recommendations:

  • If this PR addresses an open issue, please link the issue in the PR description and claim it.

Note: this comment updates automatically after changes to the PR. Updates may take up to half an hour.

@meta-codesync

meta-codesync Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D132905585. (Because this pull request was imported automatically, there will not be any future comments.)

@github-actions

Copy link
Copy Markdown

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@kinto0 kinto0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants