You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Restructure generator.py according to the utilities #8
As of now, there are multiple functionalities implemented in a single file. Most of the generator functions are Faker oriented. Maybe a separate file handles such functions.
Yeah basically the purpose of generator is to generate data. Now that maybe using Faker, built-in functions, or any other way. generator.py should be in such a way, that it should not contain much of a repeated code, or functions.
Activity
theycallmemac commentedon Oct 1, 2017
Just had a look at this. You want the functions using
Fakerto be separated from the few that don't?ashwini0529 commentedon Oct 1, 2017
Yeah basically the purpose of
generatoris to generate data. Now that maybe usingFaker,built-infunctions, or any other way.generator.pyshould be in such a way, that it should not contain much of a repeated code, or functions.theycallmemac commentedon Oct 1, 2017
So rather than having separate files handling such functions as you've said above, this is just a refactoring issue?
ashwini0529 commentedon Oct 1, 2017
Yeah kind of refactoring issue.
ashwini0529 commentedon Oct 3, 2017
Hey @theycallmemac , can you please check a comment that I made on your PR?
That would be ready to merge then. 🎉
theycallmemac commentedon Oct 3, 2017
Isn't it merged already?