Repository navigation
Conversation
Use vswhere to find installations including Build Tools, select the native ARM64 host toolchain when appropriate, and report setup failures before invoking MSBuild. Preserve existing developer prompts and all output architectures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 906b9e0e-c29f-48c8-8962-5afae98fecc8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fix
build.batbootstrap on Windows ARM64 and Visual Studio Build Tools installations:vswhere -products *instead of assuming a fixed Community-edition path.arm64_x64on ARM64, including under emulation; keepamd64elsewhere.Preserve already-configured developer prompts and the existing targets: x64 application, Win32/x64/ARM64 engines. This does not add a native ARM64 application or improve runtime speed.
One file, 14 added lines and one removed line. Independent of the catalog performance change, based on current
main(0cfc358, 2.0.0-alpha.7).Evidence
On ARM64 Windows with Visual Studio 2022 Build Tools 17.14 (MSVC 14.44, SDK 10.0.26100):
MSBuild.exeis not found.build.bat Releasediscovers Build Tools, initializesarm64_x64, and builds all four current-upstream Release targets with zero warnings/errors. Changed current-upstream C++ sources were compiled and linked, not merely checked as up-to-date.No Visual Studio installation with C++ build tools was found.No dependency, engine, or output-architecture changes. x64-host and preconfigured-prompt paths retain the existing behavior but were not separately executed on an x64 machine.