Repository navigation
FIX: Support inline images in Text with lineHeight - #48994
Closed
rodriguescarson wants to merge 1 commit into
Closed
rodriguescarson wants to merge 1 commit into
rodriguescarson wants to merge 1 commit into
Conversation
cipolleschi
requested changes
Feb 3, 2025
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
This fix is for the Old Architecture only. Can you check how the New Architecture behaves and, eventually, fix it there as well?
The text component for the New Architecture is RCTParagraphComponentView. It uses the AttributedString abstraction.
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request addresses the image overflow issue in React Native's component when
lineHeightis specified. By modifying the native code forRCTTextView.mm, we have:setTextStoragemethod to handle images withinNSTextStorage.drawRect:method to ensure images are drawn correctly.These changes ensure proper positioning and rendering of images, fixing the long-standing overflow issue.
Changelog:
[IOS] [FIXED] - Resolved image overflow issue in component when
lineHeightis specified by updatingRCTTextView.mm.Test Plan:
Example test steps:
lineHeightvalues and observe rendering.