Repository navigation
Restore Fantom DevTools launching with FANTOM_DEBUG_JS (#59410) - #59410
Open
rubennorte wants to merge 2 commits into
Open
rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127171074. |
Summary: Register DevTools middleware with `runServer`'s `unstable_extraMiddleware` option instead of overriding `server.enhanceMiddleware`. This hook is supported by both Metro from source and the pinned published Metro 0.87.0 package, so Fantom starts without the deprecation warning and remains compatible with OSS checks. DevTools forwards unhandled requests to Metro. Remove the unused `connect` and `ConfigT` imports and the unnecessary configuration mutation. Changelog: [Internal] Differential Revision: D127152281
Summary: Restore DevTools launching when `FANTOM_DEBUG_JS` is set. Use a Chrome app window instead of the standalone shell, which can fail to start in restricted launch environments. Request DevTools from the runner after the inspector target registers, deduplicate launch requests for each tester connection, and run debugging sessions in band. Report failed launcher commands in the test output. Changelog: [Internal] Differential Revision: D127171074
meta-codesync
Bot
changed the title
FANTOM_DEBUG_JSFANTOM_DEBUG_JS (#59410)
rubennorte
force-pushed
the
export-D127171074
branch
from
October 23, 2026 15:54
17a8295 to
8f11048
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Restore DevTools launching when
FANTOM_DEBUG_JSis set. Use a Chrome app window instead of the standalone shell, which can fail to start in restricted launch environments. Request DevTools from the runner after the inspector target registers, deduplicate launch requests for each tester connection, and run debugging sessions in band. Report failed launcher commands in the test output.Changelog: [Internal]
Differential Revision: D127171074