Repository navigation
fix(sdk): mark the signature step item as failed when the check fails - #1175
Merged
pedromcunha-uneven merged 1 commit intoNov 9, 2026
Conversation
The refund branch sets checkStatus to refund before throwing, like the transaction and websocket paths do for their final statuses. The failure branch threw without setting it, so the item kept pending (or no status) after the step failed.
Contributor
|
@erkancamli is attempting to deploy a commit to the Uneven Labs Team on Vercel. A member of the Team first needs to authorize it. |
 [Medium impact] This PR appears safe to merge.
|
pedromcunha-uneven
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to @pedromcunha-uneven's review on #1144: the
failurebranch of the signature step status check now setsstepItem.checkStatus = 'failure'before throwing, like therefundbranch next to it and the websocket handler (websocketHandlers.ts) do. Before, the item keptpending(or no status) after the step had failed.Tests in
signatureStep.test.ts:checkStatusto befailure.undefinedafter a failure; it now expectsfailure(the Hyperliquid hash lookup that resolves afterwards still leaves it alone).Both fail without the change and pass with it. The SDK suite passes (103 tests), prettier and the changeset lint are clean.