Repository navigation
EPMRPP-114938 || Fix incorrect text concatenation in schema.org JSON-LD - #1178
allaprischepa merged 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Walkthrough
ChangesSchema.org text parsing
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The Schema.org text-spacing change is mergeable after normal checks; no concrete blocking issue was established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. I’m a rabbit parsing blocks with care Comment |
Changes
Problem:
mdast-util-to-stringconcatenates text from all child nodes without any separator. For inline nodes, this is correct – they sit inside a single paragraph and don't need spacing. However, block-level nodes (paragraph, heading, list, listItem, blockquote, code) are structurally separate pieces of content, so adjacent blocks were being joined without a space: e.g.,"Verify Docker & Compose Installationdocker --version".Fix: Added a
BLOCK_CHILD_TYPEScheck innodeToText. When a node's children include any block-level element, the function recursively processes each child and joins the results with a single space. When all children are inline nodes, it falls back tomdastToStringas before.Affected pages:
FAQ– list items in answersDeploy with Docker– ordered list steps (HowTo schema)Deploy without Docker– component version listsHardware Requirements– PostgreSQL config blocksAWS Load Balancer Integration on EKS,Basic monitoring configuration,Setup TLS / HTTPS Docker Compose + Traefik v2– prerequisite/summary listsLinks
EPMRPP-114938
Visuals
Before:

After:

Before:

After:

Before:

After:

Summary by CodeRabbit