Repository navigation
Conversation
lochstar
had a problem deploying
to
CI with Mapbox Tokens
July 30, 2026 00:59 — with
GitHub Actions
Failure
lochstar
had a problem deploying
to
CI with Mapbox Tokens
July 30, 2026 00:59 — with
GitHub Actions
Failure
lochstar
had a problem deploying
to
CI with Mapbox Tokens
July 30, 2026 00:59 — with
GitHub Actions
Failure
mfazekas
requested changes
Oct 15, 2026
mfazekas
left a comment
Contributor
There was a problem hiding this comment.
Thanks @lochstar, this makes sense. Requiring a long-press before dragging a PointAnnotation on Android avoids accidental drags while panning, and matches iOS, so I'm happy for it to become the Android default.
Two requests before we merge:
- Please add an option to opt back into the current behaviour, where a draggable annotation starts dragging right away without a long-press. Some apps rely on that, so they need a way to keep it.
- Please move the
RNMBXFillLayerManageraboveLayerID/belowLayerIDnull-handling fix into its own PR. It looks good, but it's unrelated, and keeping it separate makes both easier to review and revert.
Thanks again!
…OS implementation
lochstar
force-pushed
the
android-longpress-draggable-pointannotation
branch
from
October 15, 2026 21:13
011afe3 to
6cf2878
Compare
Contributor
Author
|
Hey @mfazekas, thanks for checking this one out. I've made the requested changes. Let me know if you'd like anything else changed. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is based on an old discussion at #3425.
When multiple draggable
PointAnnotationare visible on a pan-able map, it is very easy to accidentally trigger the drag event of thePointAnnotationwhilst moving around the map.This issue only exists on Android, iOS already implements a long-press to start the drag. This PR aligns the behaviour.
A prop has been added to restore the current Android behaviour:
androidInstantDraggable. I've added a toggle to the example app on the "Show Point Annotation" page to test the behaviour.How to verify
Android only: Example App > Annotations > Show Point Annotation:
onDragStart,onDrag,onDragEndWhilst testing in the example app, I noticed there is a crash when pressing "Render Polygon above", fix is here: #4362
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)