replace plugin. "delimiters" config is broken by "escape" internal mutation

Rollup Plugin Name: @rollup/plugin-replace
Rollup Plugin Version: 2.4.2 (currently latest)
Rollup Version: 2.50.6
Operating System (or Browser): macos (but it's irrelevant in this case)
Node Version: 16 (but it's irrelevant in this case)
Link to reproduction: https://stackblitz.com/edit/rollup-plugin-replace-broken-delimiters-option

Expected Behavior

The delimiters option that is matching the default value should work the same

Actual Behavior

Unfortunately, the escape internal function that is supposed to escape RegExp string malfunctions.
So it's impossible to reproduce the current default behavior because of that.

it's also preventing to configure as this PR suggests fix(replace)!: issues with nested objects replacements #903

Any update on this?

As you said, it's impossible to provide any special RegExp character (such as \b) because of this escape function.

// Current escape function
function escape(str) {
  return str.replace(/[-[\]/{}()*+?.\\^$|]/g, '\\$&');
}

new RegExp(escape('\\b')) // Result: /\\b/
new RegExp(escape('\b')) // Result: /�/
// How do we get /\b/ ?

Perhaps an option should be added that allows bypassing this function when creating the pattern?

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ

This is definitely a real bug. The delimiter option really should not run through escape.

@ef4

@ef4 please read the bot's message. If you'd like to open a PR for this, we'd be happy to reopen.

Btw, just to provide clarity why I didn't provide a PR for this issue.
The default behavior in #903 resolved the need for me to pass custom delimiters.

Appreciate the clarity. If someone picks this up, we'll reopen. Thanks again for the work on #903

Navigation Menu

Repository navigation

replace plugin. "delimiters" config is broken by "escape" internal mutation #904

Expected Behavior

Actual Behavior

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

replace plugin. "delimiters" config is broken by "escape" internal mutation #904

Description

Expected Behavior

Actual Behavior

Activity

vegeta897 commented on Jul 31, 2021

stale commented on Oct 1, 2021

ef4 commented on Oct 28, 2021

shellscape commented on Oct 29, 2021

o-alexandrov commented on Oct 29, 2021

shellscape commented on Oct 29, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions