Repository navigation
Fix regressions of bundler/inline's forked install - #10048
Merged
Merged
Conversation
The forked installer child ran the script's at_exit hooks on its way out and reported a failure by making the parent exit, so the script could not rescue it. The child now always ends with exit!, even when flushing its output to a closed pipe fails, and when it fails the parent installs again to raise the error where the script can handle it. Co-authored-by: Samer Masry <smasry@agero.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After a forked install the parent resolves again to set up the bundle, which repeated the metadata and resolution lines the child had already printed. Co-authored-by: Samer Masry <smasry@agero.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
securerandom is now loaded as Gem::SecureRandom, while building native extensions still activates tempfile, tmpdir and open3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hsbt
force-pushed
the
claude/jovial-bassi-90d735
branch
from
November 10, 2026 21:13
78cfc8c to
0efc389
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 4.1.0.beta1,
bundler/inlineinstalls gems from a forked child (#7941). The child runs the script'sat_exithooks a second time, an install failure ends the script throughexitinstead of raising an error the script can rescue, and "Fetching gem metadata" and "Resolving dependencies..." are printed twice.The child now ends with
exit!. When it fails, the parent installs again in its own process, so the error is raised where the script can rescue it. The parent's setup after a forked install no longer prints resolution output.The fork stays, because building native extensions in the script's process activates default gems such as
tempfileand overrides a Gemfile pin on them. The specs are adapted from #10033, thanks to smasry.Generated with Claude Code