Upgrade to v8 4.5 by cowboyd · Pull Request #178 · rubyjs/libv8

cowboyd · 2015-07-03T20:38:09Z

This upgrades to the 4.5 build process which uses the Chromium depot tools.

This completely removes the v8 source as a submodule and instead uses fetch and gclient sync to configure all build dependencies.

Add submodules for icu and Chrome's build tools and bump the v8 version to 3.27.23.1

Add REE, Ruby 2.1.2 and Rubinius 2

cowboyd · 2015-07-13T06:32:38Z

Sheesh. I'm the guy who fights always fights with the v8 build and ends up on the floor unconsious.

There is a standalone_static_library option referenced in gyp/generators/make.py, that can be turned on somehow. I thought I'd figured it out, but apparently not. If we can somehow turn that on, then we can actually build linux binaries.

ignisf · 2015-07-13T12:32:10Z

It was a tough one...

-rw-r--r--  1 ignisf ignisf  10M 13 юли 15,29 libv8-4.5.95.5-x86_64-linux.gem

cowboyd · 2015-07-13T12:41:36Z

You magnificent bastard.

Instruct GYP to create a standalone static library

cowboyd · 2015-07-13T16:59:29Z

I noticed with this change, that it puts the archives in the main product dir, just like on darwin, and freebsd, so no need to check in two places for the object files, which was a hack to begin with.

I think we're getting damn close to master here.

* doing a full clone of the depot tools. I thought that I could save some time, but it means that building the binaries is not idempotent * using rvm instead of system ruby

cowboyd · 2015-07-13T21:09:01Z

So after the remaining 2 PR's is there any work left to do before merging to master?

ignisf · 2015-07-13T21:17:23Z

What I think would be nice is to package only the needed sources in the source distribution of the gem and not execute depot tools when it's installed. IIRC the patcher needed to be executed upon installation because there are environment-specific patches that need to be applied. The source however is the same for everybody.

This does not stop us from merging into master.

ignisf · 2015-07-13T21:18:34Z

Disregard that.. This would break using with gem ... github: ...

cowboyd · 2015-07-13T21:40:17Z

Believe it or not, I actually tried that at first, but

All the crap depot tools pooped into vendor/v8 was something like 125M
the build lost its mind when it found that vendor/v8 was not a git repot.

use container based builds on travis

enhance the binary builders

NFS requires a host-only network to be present.

FreeBSD Vagrant box

These patches were not getting applied anyway. If the arm patches are still needed, they will be applied as necessary at a later stage.

Install and use g++ 4.8 in Travis

Add a Requirements section and update the README

Remove stale patches for arm and Apple clang 5.1

mintrigue · 2016-02-23T15:45:01Z

Is this upgrade dead?

jarredholman · 2016-02-24T01:48:57Z

On the windows side of things, getting the build working is a nightmare.

ignisf added 30 commits June 10, 2014 14:19

Bump v8 version to 3.27.23

f5ebcfe

Remove unnecessary files from the gem

b5a4394

Bring patchset up to speed with 3.27.23

c0c27e2

Add submodule dependencies and update v8

9eee915

Add submodules for icu and Chrome's build tools and bump the v8 version to 3.27.23.1

Link v8 dependency dirs to submodule directories

4ec06f8

Simplify checkout and patch processes

62c010a

GCC 4.9 is a supported compiler

1a4c478

Silence warnings

f7e706e

Specify the correct directory for the patches

3c143f8

Route build warnings to stdout

7622b9d

Update Travis configuration

44b4e40

Add REE, Ruby 2.1.2 and Rubinius 2

Bump v8 to 3.27.24

3cc2340

Remove git-svn from Travis configuration

108c3c7

Add new submodules to the clean task

68fca9a

Bump v8 to 3.27.28

8170ba3

Simplify Rakefile

6252277

Attempt to work around 10 minute Travis build limit

d198236

Remove unused checkout logic

1ba8077

Cosmetic changes to the Rakefile

0e9aa52

Run bundle install concurrently on Travis

3034f80

Refactor the compiler detection module

80a8dc0

Add specs for the compiler classes

4a0b861

Extract the CompilerHelpers module to spec/support

ac4ea12

The RSpec spies syntax is now available by default

1a9cbd5

For now we're still using RSpec 2.14

3a842d9

Do not use new hash literal syntax

a1314e5

Escape command before interpolating in Regexp

c226b41

Fix a bug in compiler version parsing

ead7283

Add Apple LLVM compiler

7b185f4

Change spec wording

f142f28

Instruct GYP to create a standalone static library

f5dc429

Merge pull request #185 from cowboyd/build-standalone-static-library

020b648

Instruct GYP to create a standalone static library

enhance the binary builders by

0f96678

* doing a full clone of the depot tools. I thought that I could save some time, but it means that building the binaries is not idempotent * using rvm instead of system ruby

cowboyd and others added 13 commits July 13, 2015 16:45

Merge pull request #184 from cowboyd/container-based-travis

c3ad860

use container based builds on travis

Merge pull request #186 from cowboyd/update-binary-builds

054c56d

enhance the binary builders

Add a 64-bit FreeBSD 10.1 build

0fa385d

Add amd64 to arch detection

10e62c8

Use NFS for Vagrant shared folders for FreeBSD

9d305e1

Confiure the host-only network adapter for FreeBSD

4152edf

NFS requires a host-only network to be present.

Merge pull request #190 from cowboyd/freebsd-vagrant-box

4504cdc

FreeBSD Vagrant box

Install and use g++ 4.8 in Travis

6b57f9d

Add a Requirements section and update the README

bc7e50c

Remove stale patches for arm and Apple clang 5.1

1f540a2

These patches were not getting applied anyway. If the arm patches are still needed, they will be applied as necessary at a later stage.

Merge pull request #191 from cowboyd/use-gcc48-in-travis

e4a6d63

Install and use g++ 4.8 in Travis

Merge pull request #192 from cowboyd/readme-update-for-4.5

92792f2

Add a Requirements section and update the README

Merge pull request #193 from cowboyd/remove-unnecessary-patches

0b97c04

Remove stale patches for arm and Apple clang 5.1

ignisf mentioned this pull request Oct 21, 2015

segfault rubyjs/therubyracer#391

Closed

ignisf merged commit 0b97c04 into master May 13, 2016

ignisf deleted the 4.5 branch May 13, 2016 20:28

ignisf mentioned this pull request Jun 15, 2016

Making it possible to use V8 snapshots rubyjs/mini_racer#21

Merged

Navigation Menu

Repository navigation

Upgrade to v8 4.5 - #178

Upgrade to v8 4.5#178
ignisf merged 129 commits into
masterfrom
4.5

cowboyd commented Jul 3, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

ignisf commented Jul 13, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

ignisf commented Jul 13, 2015

Uh oh!

ignisf commented Jul 13, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

mintrigue commented Feb 23, 2016

Uh oh!

jarredholman commented Feb 24, 2016

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

cowboyd commented Jul 3, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

ignisf commented Jul 13, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

ignisf commented Jul 13, 2015

Uh oh!

ignisf commented Jul 13, 2015

Uh oh!

cowboyd commented Jul 13, 2015

Uh oh!

mintrigue commented Feb 23, 2016

Uh oh!

jarredholman commented Feb 24, 2016

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants