Skip to content

Max Memory pre-fatal alloc termination - #36

Closed
seanmakesgames wants to merge 6 commits into
rubyjs:masterfrom
comcode-org:fatals
Closed

seanmakesgames wants to merge 6 commits into
rubyjs:masterfrom
comcode-org:fatals

Conversation

@seanmakesgames

Copy link
Copy Markdown
Contributor

No description provided.

eval_params.max_mem = 0;
VALUE max_mem = rb_iv_get(self, "@max_mem");
if (max_mem != Qnil) {
eval_params.max_mem = (useconds_t)NUM2LONG(max_mem);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size_t, not useconds_t

@BrianHawley

Copy link
Copy Markdown

Probably best to add .DS_Store and .vscode to the .gitignore list, rather than add them here.

@seanmakesgames

Copy link
Copy Markdown
Contributor Author

One of my players is working on a new PR with updated v8 apis. Closing this one.

@seanmakesgames
seanmakesgames deleted the fatals branch May 9, 2018 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants