Repository navigation
Conversation
Task list checkboxes are disabled and purely presentational, so mark them aria-hidden instead of leaving them without an accessible name. Fixes rust-lang#3212 test: update tasklists snapshot for aria-hidden checkboxes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3225 (author does not seem to respond), Fixes #3212
was already approved, just needed to squash commits ; all I did was cherry pick and squash
Below original PR description.
Fixes #3212
Task list checkboxes render as disabled inputs with no accessible name. Since they are disabled and purely presentational, this marks them aria-hidden so checkers and screen readers skip them.
Changes: