You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add createNoPaintDatasets method and run on driver to avoid "exceeded the rate limit for object mutation operations ... see https://cloud.google.com/storage/docs/gcs429" exceptions
The reason will be displayed to describe this comment to others. Learn more.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟡 Changes recommended
Approval is blocked because there are still open review findings in Wafer6061Inpainter.java, specifically nit-level logging issues that duplicate identifiers and omit dataset-path context, making the logs less actionable.
Reduces GCS 429 “object mutation rate limit” errors during MultiSEM inpainting by moving N5 “no paint” dataset creation to the Spark driver and adding retry/backoff around dataset creation.
Changes:
Pre-create required “no paint” N5 pyramid datasets serially on the driver before executor work starts.
Add rate-limit-aware retry/backoff logic for dataset creation to handle transient GCS throttling.
Update CLI parameter help text for intensity-adjust settings.
Moves “no paint” dataset creation to a driver-side pre-step and adds rate-limit retry/backoff plus minor logging adjustments to reduce GCS 429 failures.
The reason will be displayed to describe this comment to others. Learn more.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🔵 Needs a closer look
The change is not approval-ready because there are still documented inconsistencies in user-facing documentation (CLI help text and Javadoc) that diverge from the actual default and retry/backoff behavior, requiring updates to keep operational guidance accurate.
The CLI help for this flag no longer indicates the default value, even though the default is still set in code (8000). Keeping the default in the description makes --help output self-contained and matches other parameters in this class (e.g. --maxPixelCacheGb, --renderScale).
The Javadoc says backoff is capped at 64s and ~4 minutes total, but with maxRetries=7 and delay doubling from 2s the largest delay is 128s (2,4,8,16,32,64,128) and total wait is ~254s. Please update the comment (or the retry parameters) so operators can reason about worst-case driver stall time.
With regard to "Help omits default value" issue flagged by Copilot, the com.beust.jcommander library automatically includes default values in it's help so there is no need to add them to parameter descriptions. Interestingly, Claude also wanted to include the redundant default values.
…t is easier to check locations after processing. In most cases there will only be a small number of locations, so they should not cause too much bloat in the attributes.json file. A maximum of 1000 locations will be written to attributes.json to prevent problems. All locations are logged.
…tions by changed pixels with the most changed pixel locations listed first. This ensures that in the rare case where the inpaint locations list needs to be truncated (because there are too many of them), the largest changes will be written to attributes.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add createNoPaintDatasets method and run on driver to avoid "exceeded the rate limit for object mutation operations ... see https://cloud.google.com/storage/docs/gcs429" exceptions