Repository navigation
Wip, crr cascade fix follow up - #422
SylvainSenechal wants to merge 3 commits into
Conversation
crrExistingObjects kept the replica marker only from the isReplica flag. Replicas written before the flag existed (Zenko < 2.16) only have the REPLICA status, so a cascade backfill on them wrote a plain PENDING object: once replicated further, it showed as COMPLETED instead of REPLICA on the intermediate site. Also check the REPLICA status, like ObjectMD.getReplicationIsReplica in arsenal and the replication status header in cloudserver. Issue: S3UTILS-257
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
| require('../../../crrExistingObjects'); | ||
|
|
||
| const ReplicationStatusUpdater = require('../../../CRR/ReplicationStatusUpdater'); | ||
| const expected = JSON.parse(require('fs').readFileSync('tests/conf/locationConfig.json')); |
There was a problem hiding this comment.
require('fs') inside the test body: repo rules want all require() calls at the top of the file. Add const fs = require('fs'); at the top and use it here.
| const expected = JSON.parse(require('fs').readFileSync('tests/conf/locationConfig.json')); | |
| const expected = JSON.parse(fs.readFileSync('tests/conf/locationConfig.json')); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/1 #422 +/- ##
=================================================
+ Coverage 49.06% 49.20% +0.14%
=================================================
Files 89 89
Lines 6489 6503 +14
Branches 1402 1405 +3
=================================================
+ Hits 3184 3200 +16
+ Misses 3252 3250 -2
Partials 53 53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
crrExistingObjects handled every site as a CRR site: cloud backends got the destination bucket and role of the rule, and S3C 9.5 objects got their top-level destination and role copied on them. Cloudserver writes neither on a cloud backend: the location gives them. The new optional LOCATION_CONFIG_FILE gives the location config of cloudserver: sites with a public cloud type (aws_s3, azure, gcp) get no bucket and no role, and match an existing backend on the site only. Without it, nothing changes. Issue: S3UTILS-257
Issue: S3UTILS-257
7bf1224 to
4928bcd
Compare
Issue: S3UTILS-257
Wip