Skip to content

Wip, crr cascade fix follow up - #422

Draft
SylvainSenechal wants to merge 3 commits into
development/1from
improvement/S3UTILS-257
Draft

SylvainSenechal wants to merge 3 commits into
development/1from
improvement/S3UTILS-257

Conversation

@SylvainSenechal

Copy link
Copy Markdown
Contributor

Issue: S3UTILS-257

Wip

crrExistingObjects kept the replica marker only from the isReplica flag.
Replicas written before the flag existed (Zenko < 2.16) only have the
REPLICA status, so a cascade backfill on them wrote a plain PENDING
object: once replicated further, it showed as COMPLETED instead of
REPLICA on the intermediate site.

Also check the REPLICA status, like ObjectMD.getReplicationIsReplica in
arsenal and the replication status header in cloudserver.

Issue: S3UTILS-257
@bert-e

bert-e commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue S3UTILS-257 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.21.0

Please check the Fix Version/s of S3UTILS-257, or the target
branch of this pull request.

Comment thread tests/unit/CRR/crrExistingObjects.js Outdated
require('../../../crrExistingObjects');

const ReplicationStatusUpdater = require('../../../CRR/ReplicationStatusUpdater');
const expected = JSON.parse(require('fs').readFileSync('tests/conf/locationConfig.json'));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require('fs') inside the test body: repo rules want all require() calls at the top of the file. Add const fs = require('fs'); at the top and use it here.

Suggested change
const expected = JSON.parse(require('fs').readFileSync('tests/conf/locationConfig.json'));
const expected = JSON.parse(fs.readFileSync('tests/conf/locationConfig.json'));

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.20%. Comparing base (93bf47c) to head (7bf1224).

Additional details and impacted files
@@                Coverage Diff                @@
##           development/1     #422      +/-   ##
=================================================
+ Coverage          49.06%   49.20%   +0.14%     
=================================================
  Files                 89       89              
  Lines               6489     6503      +14     
  Branches            1402     1405       +3     
=================================================
+ Hits                3184     3200      +16     
+ Misses              3252     3250       -2     
  Partials              53       53              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

crrExistingObjects handled every site as a CRR site: cloud backends got
the destination bucket and role of the rule, and S3C 9.5 objects got
their top-level destination and role copied on them. Cloudserver writes
neither on a cloud backend: the location gives them.

The new optional LOCATION_CONFIG_FILE gives the location config of
cloudserver: sites with a public cloud type (aws_s3, azure, gcp) get
no bucket and no role, and match an existing backend on the site only.
Without it, nothing changes.

Issue: S3UTILS-257
@SylvainSenechal
SylvainSenechal force-pushed the improvement/S3UTILS-257 branch from 7bf1224 to 4928bcd Compare November 5, 2026 09:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants