Repository navigation
fix(samplers): refuse shallow copies and reset open passes on copy (merge after 302) - #304
Draft
selmanozleyen wants to merge 2 commits into
Draft
selmanozleyen wants to merge 2 commits into
selmanozleyen wants to merge 2 commits into
Conversation
…ase instead of a subclass, since its batches mix classes and so break ClassSampler's one-class-per-batch contract. Seeded output of both samplers is unchanged.
…mber generator, and track open passes in a shared mixin that resets them when a sampler or Loader is deep-copied or pickled. A ClassSampler, DistributedSampler or Loader copied mid-pass no longer refuses mask changes or datasets, or miscounts its shard's batches.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 91.70% 91.72% +0.01%
==========================================
Files 18 18
Lines 1519 1522 +3
==========================================
+ Hits 1393 1396 +3
Misses 126 126
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #303
Sorry I couldn't do stacked PR's because I cant push branches upstream
disclaimer: opus 5.5 was used in writing this code