Repository navigation
Improve granularity of benchmarks - #122
Merged
Merged
Conversation
To provide better baselines for perf work, etc... It unfortunately requires exposing a few functions as public, though they are hidden from the docs and re-exported under a `_benchable` mod
AaronO
force-pushed
the
bench/granularity
branch
from
April 13, 2023 20:54
a69c6bb to
e39f3f4
Compare
seanmonstar
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To provide better baselines for perf work, etc...
It unfortunately requires exposing a few functions as public, though they are hidden from the docs and re-exported under a
_benchablemodI wanted to land this first to have a solid baseline to frame the other performance improvements I'll submit shortly
Current baseline