Skip to content

Exclude fsspec versions causing intermittant test failures - #625

Merged
mergify[bot] merged 2 commits into
sgkit-dev:mainfrom
tomwhite:exclude-flaky-fsspec-versions
Jul 8, 2021
Merged

mergify[bot] merged 2 commits into
sgkit-dev:mainfrom
tomwhite:exclude-flaky-fsspec-versions

Conversation

@tomwhite

@tomwhite tomwhite commented Jul 8, 2021

Copy link
Copy Markdown
Member

Fixes #617 until the next release of fsspec which should contain a fix for the underlying issue (see linked issue in #617)

@tomwhite tomwhite added bug Something isn't working process + tools auto-merge Auto merge label for mergify test flight labels Jul 8, 2021
@tomwhite

tomwhite commented Jul 8, 2021

Copy link
Copy Markdown
Member Author

For reference, this is the fsspec commit with the change that caused the test failures: fsspec/filesystem_spec@328141a

@jeromekelleher jeromekelleher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jul 8, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #625 (c483a3b) into main (fa0547b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #625   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2798      2798           
=========================================
  Hits          2798      2798           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0547b...c483a3b. Read the comment docs.

@mergify
mergify Bot merged commit 44726f1 into sgkit-dev:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Auto merge label for mergify test flight bug Something isn't working process + tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI tests are failing with "ResourceWarning: unclosed scandir iterator"

3 participants