Repository navigation
feat: add user_connections to the app manifest features model - #1662
Open
WilliamBergamin wants to merge 1 commit into
Open
WilliamBergamin wants to merge 1 commit into
WilliamBergamin wants to merge 1 commit into
Conversation
Adds AppManifest.UserConnections (isEnabled, authHosts) on Features so apps.manifest.create, update and export keep the standardized app authentication settings instead of dropping them. The export json-logs sample and SampleObjects carry the field so generated response types pick it up. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
=========================================
Coverage 72.98% 72.99%
- Complexity 4630 4631 +1
=========================================
Files 486 486
Lines 14632 14632
Branches 1524 1524
=========================================
+ Hits 10679 10680 +1
+ Misses 3049 3048 -1
Partials 904 904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
WilliamBergamin
marked this pull request as ready for review
October 22, 2026 22:40
zimeg
approved these changes
Oct 22, 2026
zimeg
left a comment
Member
There was a problem hiding this comment.
@WilliamBergamin It's nice to find these changes with test while having a coffee of me own ☕ 😉
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
features.user_connectionsmanifest property (is_enabled,auth_hosts) toAppManifest, so apps that opt into standardized app authentication can pass it toapps.manifest.create,updateandvalidate, andapps.manifest.exportkeeps it instead of dropping it.AppManifest.UserConnections:isEnabledandauthHostsonAppManifest.Features. Slack validates that both are present.apps.manifest.exportsample:json-logs/samples/api/apps.manifest.export.jsonandSampleObjectsinclude the field, so generated response types (node-slack-sdk'sAppsManifestExportResponse) pick it up.Testing
With a configuration token, create an app whose manifest enables user connections, then export it:
isEnabledtrue withexample.cominauthHosts.authHostsand confirmapps.manifest.validatereports the missing field.Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.
🤖 Generated with Claude Code