Skip to content

feat: add user_connections to the app manifest features model - #1662

Open
WilliamBergamin wants to merge 1 commit into
mainfrom
manifest-user-connections
Open

WilliamBergamin wants to merge 1 commit into
mainfrom
manifest-user-connections

Conversation

@WilliamBergamin

Copy link
Copy Markdown
Contributor

This pull request adds the features.user_connections manifest property (is_enabled, auth_hosts) to AppManifest, so apps that opt into standardized app authentication can pass it to apps.manifest.create, update and validate, and apps.manifest.export keeps it instead of dropping it.

Testing

With a configuration token, create an app whose manifest enables user connections, then export it:

AppManifest manifest = AppManifest.builder()
        .displayInformation(AppManifest.DisplayInformation.builder().name("connector").build())
        .features(AppManifest.Features.builder()
                .botUser(AppManifest.BotUser.builder().displayName("connector").build())
                .userConnections(AppManifest.UserConnections.builder()
                        .isEnabled(true)
                        .authHosts(Arrays.asList("example.com"))
                        .build())
                .build())
        .build();
String appId = client.appsManifestCreate(r -> r.manifest(manifest)).getAppId();
client.appsManifestExport(r -> r.appId(appId)).getManifest().getFeatures().getUserConnections();
  1. Confirm the create succeeds and the export returns isEnabled true with example.com in authHosts.
  2. Remove authHosts and confirm apps.manifest.validate reports the missing field.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

🤖 Generated with Claude Code

Adds AppManifest.UserConnections (isEnabled, authHosts) on Features so
apps.manifest.create, update and export keep the standardized app
authentication settings instead of dropping them. The export json-logs
sample and SampleObjects carry the field so generated response types
pick it up.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.99%. Comparing base (e8352d1) to head (f2d5542).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1662   +/-   ##
=========================================
  Coverage     72.98%   72.99%           
- Complexity     4630     4631    +1     
=========================================
  Files           486      486           
  Lines         14632    14632           
  Branches       1524     1524           
=========================================
+ Hits          10679    10680    +1     
+ Misses         3049     3048    -1     
  Partials        904      904           
Flag Coverage Δ
jdk-14 72.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@WilliamBergamin
WilliamBergamin marked this pull request as ready for review October 22, 2026 22:40
@WilliamBergamin
WilliamBergamin requested a review from a team as a code owner October 22, 2026 22:40
@zimeg zimeg added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model semver:minor labels Oct 22, 2026
@zimeg zimeg added this to the 1.52.1 milestone Oct 22, 2026

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin It's nice to find these changes with test while having a coffee of me own ☕ 😉

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants