Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #5390.
Recreate the sparse-catalog TCP setup diagnostics on main
78e4de8642b4e177a7ec24b87e18c51c4e0bd684. This is a new test-only candidate, not a byte-for-byte recovery of the unavailable sealed candidate.Review and local validation
Independent source review accepted tree
04bdd47defca9b40d892ddf4816655030dda2b7bwith no blocking findings. Removing the nine diagnostic insertions restores the entire original sparse-catalog contract file byte-for-byte.Laptop qualification on macOS arm64, Go 1.26.0, with
GOMEMLIMIT=4GiB,GOMAXPROCS=2,-p 1, shared existing Go caches and an isolated temporary directory:go test -json -timeout 5m -p 1 ./nativewire -run '^TestSparseCatalogSetupFailureDiagnosticsV1$': 6 RUN / 6 PASS; package 0.813s.go test -json -timeout 30m -p 1 ./nativewire -run '^TestSparseCatalog': 32 RUN / 32 PASS; package 6.559s.go test -json -race -p 1 -timeout 12m ./nativewire -run '^TestSparseCatalog': 32 RUN / 32 PASS; package 20.564s.Commands ran from TreeDB. Both owning-scope runs include the real tampered-route parent and all nine tamper children, nonparticipant and stale/fresh route assertions, and checked original child cleanup. No failures, skips, race reports or success-path setup diagnostics were observed. All processes joined. Raw JSONL, stderr, exact commands and producer/source bindings are retained locally.
The maintained inventory refresh/check, gofmt and diff checks passed. The local commit hook ran
go fmt ./...without changing the reviewed tree.Remaining gates and limits
Windows qualification and required full latest-head CI/review/merge gates remain pending. These laptop checks do not replace them.
The original #5386 Windows failure remains unresolved and its cause remains inconclusive. This diagnostic change does not repair it, clear it or rewrite the retained historical failure.