Skip to content

What gets passed to the when prop of a Show still gets executed twice on SSR #4518

Open

Description

@AFatNiBBa

Describe the bug

Basically the same as #2406, but it still happens on the server, and has even more serious implications when you pass elements, because they get a new hydration key for each run, which doesn't happen on the client, thus creating a hydration mismatch.
This is a v1 issue

Your Example Website or App

https://playground.solidjs.com/anonymous/00265201-7751-427d-aaa4-8d1a6d4a01da

Steps to Reproduce the Bug or Issue

  1. Read the playground's output

Expected behavior

I expected "1.9.15 server: 2 reads" to be "1.9.15 server: 1 reads" both on "keyed=false" and "keyed=true"

Screenshots or Videos

No response

Platform

  • OS: Windows
  • Browser: Edge (Chromium)
  • Version: 156.0.4314.50

Additional context

  • It was fixed on the client after v1.9.4
  • Doesn't happen in v2.0.0-rc.20
  • Claude created the repro, hope it's clear
  • Doesn't seem to happen on Switch and Match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions