Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 24d616d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report for CI Build 41180735322Coverage remained the same at 89.14%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
Switchcontaining a directMatchand an array of matches renders its fallback on the server even when a nested match is true. Accessors returning matches have the same problem; the client selects the matching branch.Reuse the server's recursive child resolver before selecting a branch, without adding a memo that could swallow a throwing getter's original exception. Match selection and render-prop handling stay unchanged.
How did you test this change?
corepack pnpm@9.15.0 --dir packages/solid exec vitest run --config vitest.server.config.mjs test/server/switch-children.spec.ts: 15 passed; reverting only the source changes gives 7 failed / 8 passed. Covers ErrorBoundary error identity and client/server matching.renderToStringpreserves the original error from throwing children.corepack pnpm@9.15.0 run build --force,run test --force,run types --force, andrun coverage --force: pass; 492 client and 33 server tests, plus compiler, import and type checks.corepack pnpm@9.15.0 run formatand changed-file Prettier checks: exit 0. The nonmutating whole-repo format check reports only unchangedpackages/solid/test/array.spec.tson both base and branch; that file is excluded from this patch.