Skip to content

Check usage of jwt-cpp in Conan and CMake #369

New issue
New issue
Open
Open
Check usage of jwt-cpp in Conan and CMake#369

Description

@jonathan-r-thorpe
jonathan-r-thorpe
opened on Feb 8, 2024

Warnings on Windows 2022 builds:
'return': conversion from '__int64' to 'uint32_t', possible loss of data
https://github.com/sony/nmos-cpp/actions/runs/7818489184/job/21331360782#step:21:96

Activity

  1. jonathan-r-thorpe commented on Feb 8, 2024

    @jonathan-r-thorpe
    jonathan-r-thorpe
    on Feb 8, 2024
    ContributorAuthor

    Also Windows 2019

  2. garethsb commented on Feb 20, 2024

    @garethsb
    garethsb
    on Feb 20, 2024
    Contributor

    Warning fixed by Thalhammer/jwt-cpp@364a557 in upstream master but not included in a release yet.

    Other thing to check is whether jwt-cpp should be represented by add_library(INTERFACE) since it is header-only. For reference, see https://github.com/Thalhammer/jwt-cpp/blob/364a5572f4b46bb9f4304cb1c92acec8ddb2c620/CMakeLists.txt#L91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions