Repository navigation
Restrict Avahi to the default route's interface in CI - #538
Merged
Merged
Conversation
The ubuntu avahi setup step set allow-interfaces=eth0 in avahi-daemon.conf. Some GitHub-hosted Ubuntu runners now name their network interface enp39s0, so after the restart avahi-daemon joined no interface and the publish/browse self-test failed. Take the interface name from the default route instead. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "ubuntu avahi setup" step set
allow-interfaces=eth0in/etc/avahi/avahi-daemon.conf. Some GitHub-hosted Ubuntu runners now name their network interfaceenp39s0instead ofeth0. On those runners, avahi-daemon joined no interface after the restart, and the publish/browse self-test failed with "avahi-daemon cannot browse locally published services" (example job, runner image20261111.127.1).This change takes the interface name from the default route instead, so the step works whatever the runner calls its interface.
Only the Linux Avahi jobs are affected. The Windows jobs and the Linux jobs that build mDNSResponder don't run this step.
Co-authored-by: Gareth's 🤖 buddy