Skip to content

Fix windows warning - #540

Merged
lo-simon merged 1 commit into
sony:masterfrom
lo-simon:fix/windows-build-warning
Nov 13, 2026
Merged

lo-simon merged 1 commit into
sony:masterfrom
lo-simon:fix/windows-build-warning

Conversation

@lo-simon

Copy link
Copy Markdown
Collaborator

Because the generated main namespace and the enclosing namespace are identical, the using namespace line is redundant. To fix it, remove the redundant using fully-qualified name instead.

…e identical, the using namespace line is redundant. To fix it, remove the redundant using fully-qualified name instead
@garethsb

Copy link
Copy Markdown
Contributor

Yeah, oops. I did wonder if the first namespace ought to be named main_340e1b6 ? Shall we do that?

@garethsb

Copy link
Copy Markdown
Contributor

Regarding the ubuntu-24.04 failure which was an aborted pip install download, we could put retries around all of them, even though it's noisy, but I'm not sure if it's worthwhile...

for i in 1 2 3; do pip install -r requirements.txt && break; sleep 10; done

and similar in a few other places.

@lo-simon

Copy link
Copy Markdown
Collaborator Author

Yeah, oops. I did wonder if the first namespace ought to be named main_340e1b6 ? Shall we do that?

I don't mind, but where do you get the namespace main_340e1b6 from?

@garethsb

Copy link
Copy Markdown
Contributor

I don't mind, but where do you get the namespace main_340e1b6 from?

The commit hash at which the files were copied from main.

We should probably just stick to your approach!

@lo-simon
lo-simon merged commit 8dac192 into sony:master Nov 13, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants