You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should have as many unit tests as makes sense.
When possible, all features that can be tested with unit tests instead of integration tests will save time.
I added tests to internal packages. My idea was to also add some tests for cmd package with mocked docker dependency but as I'm not working on it right now, I'm returning the issue into todo.
@se7entyse7en Sure. Could you add the QA team to the repo and also to the metadata because I cannot do the assignment myself?
Related issue: src-d/metadata-retrieval#13
@se7entyse7en We have pending some automation of GitHub permissions by infra. Other than that, please add QA team with Write permission to any repository on demand. Thanks!
Activity
smacker commentedon Oct 1, 2019
I added tests to internal packages. My idea was to also add some tests for cmd package with mocked docker dependency but as I'm not working on it right now, I'm returning the issue into todo.
se7entyse7en commentedon Oct 1, 2019
@kyrcha will start looking into this so that we can also familiarize with the project. @kyrcha do you mind self-assigning yourself this card then?
kyrcha commentedon Oct 1, 2019
@se7entyse7en Sure. Could you add the QA team to the repo and also to the metadata because I cannot do the assignment myself?
Related issue: src-d/metadata-retrieval#13
se7entyse7en commentedon Oct 1, 2019
\cc @smola what's the policy here? maybe QA should be part of all repos by default?
se7entyse7en commentedon Oct 1, 2019
@kyrcha I'll manually add you for now 👍
smola commentedon Oct 2, 2019
@se7entyse7en We have pending some automation of GitHub permissions by infra. Other than that, please add QA team with Write permission to any repository on demand. Thanks!