Repository navigation
Expose the full AuthResponse details - #107
Merged
Merged
Conversation
…ls can be retrieved
Contributor
Author
|
My team hit a blocker where we need to be able to access some of the data in the We have a demo with our CVP early next week so I was hoping to get this in by the weekend if at all possible. |
AndrewCraswell
commented
Jul 22, 2019
AndrewCraswell
commented
Jul 25, 2019
| jwtIdToken: idToken, | ||
| account: authResponse.account, | ||
| authenticationResponse: authResponse, | ||
| jwtAccessToken: authResponse.accessToken, |
Contributor
Author
There was a problem hiding this comment.
All of the token data and account info already exists in the AuthResponse object, but I've elected to keep the previous values to prevent breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently we only expose the
Accountinfo when authentication completes. This is not sufficient because, for example, this would not give access to thestatedata which is needed for many security scenarios. The full authentication details are exposed bymsalusing theAuthResponse, and we should be returning this data and storing in Redux.Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
AuthResponseis saved in the Redux store asauthenticationResponseusing the React DevTools extension.