Repository navigation
fix(lanes): fetch hidden updateDependents from the lane scope - #10844
Open
davidfirst wants to merge 1 commit into
Open
davidfirst wants to merge 1 commit into
davidfirst wants to merge 1 commit into
Conversation
PR Summary by QodoFetch hidden lane dependents from the correct scopes
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cascade snap of a hidden lane entry (
lane.updateDependents) is only in the lane scope. The origin scope of the component has only its main history. Some flows did not sendincludeUpdateDependentswhen they fetched these entries. Thus, the fetch went to the origin scope and did not find the cascade snap.This PR sends the flag in these flows:
bit importon a lane. It fetches the hidden entries from the lane scope.The e2e covers a second cascade from a new bare scope, then
bit import, then a lane merge into main.