Testing Playground breaks Miro #351

Activity

1. chodorowicz

   added

   bugSomething isn't workingSomething isn't working

   on Sep 23, 2022
2. smeijer commented on Sep 26, 2022

   

   smeijer

   on Sep 26, 2022

   Member

   More actions

   It must be one of the patched methods on window that's causing issues. I'm happy to accept a pull that makes it safer by namespacing or even adding it behind an init function. Something like window.initTestingLibrary();

   testing-playground/devtools/src/window/testing-library.js

   Lines 26 to 41 in d85b47a

   	export function setup(view) {
   	// monkey patch `screen` to add testing library to console
   	for (const prop of Object.keys(screen)) {
   	view.screen[prop] = view.screen[prop] || augmentQuery(screen[prop]);
   	view[prop] = view.screen[prop];
   	}
   	view.getRoles = getRoles;
   	view.fireEvent = fireEvent;
   	view.getSuggestedQuery = getSuggestedQuery;
   	view.within = within;
   	view.container = view.document.body;
   	view.userEvent = userEvent;
   	view.user = userEvent;
   	}

   😕React with 😕1Reacted by Stef
3. keysmashes commented on Mar 15, 2023

   

   keysmashes

   on Mar 15, 2023

   More actions

   It's not that; I commented out the entire setup function and it's still broken.

   The issue occurs when testing-library.js is injected.

   👀React with 👀1Reacted by Stephan Meijer