Repository navigation
Conversation
Contributor
Author
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
T.dotpairs its operands by register index. Each unit numbers its local elements from the smallest physical stride up, asregister_stridesdoes. The CUDA runtime paired them by CuTe index, which counts the first mode fastest. The two agree only while each local view has at most one mode longer than 1, or lists its modes from the smallest stride up.A lane holding a (2, 4) block stored by rows beside a (2, 4) parameter met
a[l, 1, 0]withb[0, 1].What
dot_impl::contractreads both operands through views whose modes run from the smallest stride up, coalesced. A swizzled operand keeps its swizzle over the reordered affine layout. The load width is taken from the reordered views.contracttests both base pointers against the load width and reads one element at a time when either is not aligned.ops::dotpairs its operands and when it falls back to single elements.Contract
ops::dotpairslhsandrhsby register index whatever the order of their modes. An operand with one mode, which includes every kernel parameter, is read as before.Risk
The only other Dot in the repository is
dot_tiers. Each of its operands has at most one mode longer than 1, so it pairs as before.