Skip to content

Honor zero limits in projected queries - #2369

Open
IlyaKhalafi wants to merge 1 commit into
tortoise:developfrom
IlyaKhalafi:fix/projected-query-zero-limit
Open

IlyaKhalafi wants to merge 1 commit into
tortoise:developfrom
IlyaKhalafi:fix/projected-query-zero-limit

Conversation

@IlyaKhalafi

Copy link
Copy Markdown
Contributor

Description

This PR fixes values and values_list ignoring an explicit zero limit. With this, projected queries return no rows just like the original queryset.

Motivation and Context

Fixes #2368.

How Has This Been Tested?

The regression file fails before the fix and passes afterward. On Python 3.12, the SQLite suite ran with 2122 passed, 149 skipped and 2 xfailed, excluding benchmarks. make check passed too.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed

codspeed Bot commented Oct 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 21 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 24 untouched benchmarks


Comparing IlyaKhalafi:fix/projected-query-zero-limit (72ce046) with develop (536fc3a)

Open in CodSpeed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

values and values_list drop an explicit zero queryset limit

1 participant