Skip to content

Validate automatically generated datetime values - #2410

Open
IlyaKhalafi wants to merge 1 commit into
tortoise:developfrom
IlyaKhalafi:campaign30/2026-11-06/tortoise-orm
Open

IlyaKhalafi wants to merge 1 commit into
tortoise:developfrom
IlyaKhalafi:campaign30/2026-11-06/tortoise-orm

Conversation

@IlyaKhalafi

Copy link
Copy Markdown
Contributor

This PR fixes custom validators being skipped for automatic DatetimeField values. With this, generated timestamps are checked before they are assigned or written.

Fixes #2409

The SQLite suite passes with benchmarks excluded, and the required checks pass. Other database backends were not tested.

@codspeed

codspeed Bot commented Nov 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 21 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 24 untouched benchmarks


Comparing IlyaKhalafi:campaign30/2026-11-06/tortoise-orm (424936d) with develop (9fdb533)

Open in CodSpeed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic DatetimeField values bypass custom validators

1 participant