Skip to content

Required CI workflow needs Redis for Companion tests #6752

Open

Description

@kvz

Companion's real-Redis regression tests cannot run in the required PR check because the selected base workflow does not start Redis. PR #6751 exposes this existing infrastructure gap by forwarding COMPANION_REDIS_URL through Turbo rather than silently dropping it.

Evidence at PR head fb69db30186e2dd3a8f1c3a903743924c95bb36c:

  • Organization ruleset Uppy main CI requires .github/workflows/ci.yml from refs/heads/main.
  • The run's workflow page identifies base commit c7f2d1c2abe97de6cba9c7fb3149bb4a3b98b904, which has a Redis URL but no Redis startup. The job checks out the PR merge commit 89fdb93f214b9a3f81a359feab4462c2670abe27.
  • Tests (lts/*) has no Redis startup step and fails with Redis connection errors: ten new callback cases and four existing callback/uploader cases. The PR's added startup step therefore cannot affect this required run before it reaches the selected base workflow.
  • With real Redis 7.4 running locally, the same PR source passes all 281 Companion tests (including all 18 callback cases) and 75 typeconfig tests through Turbo. Root lint and typecheck pass too.

Prerequisite PR #6753 (ci-redis, head 7e0387ed92e4330649a6aef1e77e9fb5c3f1f4ae) adds only a Redis 7.4 service with a real health check to the Tests job. The exact image, port mapping, successful host connection, and failing health-check behavior were verified locally. Existing tests and Turbo environment behavior are unchanged. The prerequisite now has seven passing hosted checks, including full tests and example builds. That run still executes the selected main workflow at c7f2d1c2abe97de6cba9c7fb3149bb4a3b98b904 and has no service initialization; it cannot yet validate the added Redis service. Local checks validate that setup, and hosted confirmation remains necessary once the prerequisite reaches main.

Merge order remains a maintainer decision: review and merge #6753 first; then update #6751 from main and remove its superseded manual Start Redis step so it cannot compete with the service for port 6379. Keep the Redis URL passthrough in #6751 and rerun all required hosted checks, including the full tests and example builds, on the final fix head before considering its merge. The current #6751 head fb69db30186e2dd3a8f1c3a903743924c95bb36c is preserved. No required red check is waived, and no merge, release, deployment, or organization policy change has been performed.

🤖 Claimed by kvz on framework1/uppy since 2026-10-18 · resume: codex resume 01a14c1a-9f16-7d12-863a-93c61165431b

Activity

  1. self-assigned this
    on Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions