Skip to content

ci: start Redis for Companion tests - #6753

Open
kvz wants to merge 1 commit into
mainfrom
ci-redis
Open

kvz wants to merge 1 commit into
mainfrom
ci-redis

Conversation

@kvz

@kvz kvz commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Companion CI already sets COMPANION_REDIS_URL=redis://localhost:6379, but the required workflow selected from main never starts Redis. That blocks the real-Redis regressions in #6751; evidence is in #6752.

Add a Redis 7.4 service to the Tests job, publish port 6379, and use redis-cli ping with a 10-second health interval, 5-second timeout and five retries. GitHub Actions owns its startup, readiness wait and cleanup. This is a ten-line workflow-only prerequisite; existing test steps and Turbo environment behavior are unchanged.

Closes #6752.

Validation:

  • Parsed YAML with unique keys and compared it with main: only the Redis service differs.
  • Exercised the exact image, port mapping and health options locally: Redis 7.4.11 becomes healthy and answers PONG at localhost:6379; without a Redis server, the same health check becomes unhealthy after five failed probes. Removed both temporary validation containers and their volumes.
  • yarn check, yarn typecheck and git diff --check pass.
  • Actionlint workflow validation passes. Full actionlint reports only the same two existing ShellCheck SC2086 warnings as main.

Hosted run 39077696972 is complete on head 7e0387ed92e4330649a6aef1e77e9fb5c3f1f4ae: all seven checks pass, including the full Tests job and its example builds. It still selects ci.yml from main at c7f2d1c2abe97de6cba9c7fb3149bb4a3b98b904; the actual job has no service initialization, so this run cannot execute the added Redis service yet. These green checks validate the current base workflow and unchanged tests; local checks above validate the added Redis setup. The service needs hosted confirmation once it reaches the selected base.

Parent council review found no issues. Post-review yarn check, yarn typecheck and git diff --check also pass on the same head.

Merge is currently blocked by GitHub's required approving review from someone with write access, including when using --admin. mifi is requested. Squash auto-merge is enabled and waits for that approval and the required checks. All seven checks are green; no repository rule or required check has been bypassed.

Merge order: land this prerequisite first, then update #6751 from main and remove its superseded manual Start Redis step, which would otherwise compete with the service for port 6379. Keep #6751's Redis URL passthrough in the functional fix. Run all required hosted checks, including the complete tests and example builds, on its final head before considering its merge. The existing red required check on #6751 is not waived. This CI change does not release or deploy Companion.

🤖 Claimed by kvz on framework1/uppy since 2026-10-18 · resume: codex resume 01a14c1a-9f16-7d12-863a-93c61165431b

@kvz
kvz requested a review from mifi October 17, 2026 23:06
@changeset-bot

changeset-bot Bot commented Oct 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7e0387e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Required CI workflow needs Redis for Companion tests

1 participant