Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion CI already sets
COMPANION_REDIS_URL=redis://localhost:6379, but the required workflow selected frommainnever starts Redis. That blocks the real-Redis regressions in #6751; evidence is in #6752.Add a Redis 7.4 service to the Tests job, publish port 6379, and use
redis-cli pingwith a 10-second health interval, 5-second timeout and five retries. GitHub Actions owns its startup, readiness wait and cleanup. This is a ten-line workflow-only prerequisite; existing test steps and Turbo environment behavior are unchanged.Closes #6752.
Validation:
localhost:6379; without a Redis server, the same health check becomes unhealthy after five failed probes. Removed both temporary validation containers and their volumes.yarn check,yarn typecheckandgit diff --checkpass.Hosted run 39077696972 is complete on head
7e0387ed92e4330649a6aef1e77e9fb5c3f1f4ae: all seven checks pass, including the full Tests job and its example builds. It still selectsci.ymlfrom main atc7f2d1c2abe97de6cba9c7fb3149bb4a3b98b904; the actual job has no service initialization, so this run cannot execute the added Redis service yet. These green checks validate the current base workflow and unchanged tests; local checks above validate the added Redis setup. The service needs hosted confirmation once it reaches the selected base.Parent council review found no issues. Post-review
yarn check,yarn typecheckandgit diff --checkalso pass on the same head.Merge is currently blocked by GitHub's required approving review from someone with write access, including when using
--admin.mifiis requested. Squash auto-merge is enabled and waits for that approval and the required checks. All seven checks are green; no repository rule or required check has been bypassed.Merge order: land this prerequisite first, then update #6751 from main and remove its superseded manual
Start Redisstep, which would otherwise compete with the service for port 6379. Keep #6751's Redis URL passthrough in the functional fix. Run all required hosted checks, including the complete tests and example builds, on its final head before considering its merge. The existing red required check on #6751 is not waived. This CI change does not release or deploy Companion.🤖 Claimed by kvz on
framework1/uppysince 2026-10-18 · resume:codex resume 01a14c1a-9f16-7d12-863a-93c61165431b