Repository navigation
Conversation
fetchKeys had no timeout and followed redirects, so a slow or redirecting credentialsURL could hold an OAuth request open or send the credential request parameters to another host. Time out after 10s and don't follow redirects, matching the native Storage API calls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HFpWnyhntvDRifoVg51hVB Co-authored-by: Mikael Finstad <finstaden@gmail.com>
🦋 Changeset detectedLatest commit: 13fefde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
With followRedirect off, got treats a 3xx as success, so a redirect surfaced as a confusing 'Received no remote credentials' or JSON parse error. Throw an error naming the redirect target instead, assert it in the test, and tell operators in the changeset to configure the final URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HFpWnyhntvDRifoVg51hVB Co-authored-by: Mikael Finstad <finstaden@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchKeys(remote OAuth credentials viacredentialsURL) had no timeout and followed redirects. A slow endpoint could hold the OAuth request open indefinitely, and a redirecting one would have the credential request parameters re-POSTed to another host.Changes
credentialsURL; it's operator configuration, so a redirect is treated as a failure. This matches how the native Transloadit Storage provider calls Transloadit's API.@uppy/companion.Not changed
No stricter response validation: fields are already type-checked where they're used (
origins,transloadit_gateway), and a strict schema risks rejecting real-world responses (e.g. the empty-string gateway case).🤖 Generated with Claude Code
https://claude.ai/code/session_01HFpWnyhntvDRifoVg51hVB