Skip to content

Fix Partial tree not complete crash in provider search - #6742

Open
jbednar97 wants to merge 3 commits into
transloadit:mainfrom
Autoenhance-ai:dev-jb-provider-views-fix
Open

jbednar97 wants to merge 3 commits into
transloadit:mainfrom
Autoenhance-ai:dev-jb-provider-views-fix

Conversation

@jbednar97

Copy link
Copy Markdown

Problem

Searching in a Dropbox account that has shared items not mounted in the user's Dropbox crashes the whole Dashboard with:

Error: Partial tree not complete

Dropbox returns no path_lower for those items, so Companion's Dropbox adapter sends the requestPath "undefined" (encodeURIComponent(undefined)).

ProviderView#search builds each result's partial-tree node id from the path segments of its requestPath (%2Fundefined), but saves the raw requestPath (undefined) as the search result id. When the search results view renders, it can't find that id in the partial tree and throws. The throw happens during render, so the whole Dashboard goes down.

Changes

packages/@uppy/core/src/provider-views/ProviderView/ProviderView.tsx:

  • #search: skips any result whose requestPath doesn't match the node id built from its segments (or has no segments), and logs a warning for it. Only the ids actually added to the partial tree are saved as searchResults.
  • #renderSearchResults: drops ids missing from the partial tree instead of throwing, so any other mismatch can't crash rendering.

@changeset-bot

changeset-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2fa30c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@uppy/core Patch
uppy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbednar97

Copy link
Copy Markdown
Author

Related to issue: #6743

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant