Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 2fa30c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks done
Author
|
Related to issue: #6743 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Searching in a Dropbox account that has shared items not mounted in the user's Dropbox crashes the whole Dashboard with:
Dropbox returns no
path_lowerfor those items, so Companion's Dropbox adapter sends therequestPath"undefined"(encodeURIComponent(undefined)).ProviderView#searchbuilds each result's partial-tree node id from the path segments of itsrequestPath(%2Fundefined), but saves the rawrequestPath(undefined) as the search result id. When the search results view renders, it can't find that id in the partial tree and throws. The throw happens during render, so the whole Dashboard goes down.Changes
packages/@uppy/core/src/provider-views/ProviderView/ProviderView.tsx:#search: skips any result whoserequestPathdoesn't match the node id built from its segments (or has no segments), and logs a warning for it. Only the ids actually added to the partial tree are saved assearchResults.#renderSearchResults: drops ids missing from the partial tree instead of throwing, so any other mismatch can't crash rendering.