Repository navigation
Remove useless async modifiers - #6776
Open
remcohaszing wants to merge 3 commits into
Open
remcohaszing wants to merge 3 commits into
remcohaszing wants to merge 3 commits into
Conversation
This change removes the unnecessary `async` modifiers from all functions. A Biome rule is used to enforce this. The problem with `async` is that it infects its caller, which now also needs to be async. Callbacks should basically never use the `Promise` return type. They should use `PromiseLike` instead, which is compatible with other thenables as well. But even better is to allow a synchronous value as well. That’s what `Promisable` from `type-fest` does.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🦋 Changeset detectedLatest commit: edd87e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the unnecessary
asyncmodifiers from all functions. A Biome rule is used to enforce this.The problem with
asyncis that it infects its caller, which now also needs to be async.Callbacks should basically never use the
Promisereturn type. They should usePromiseLikeinstead, which is compatible with other thenables as well. But even better is to allow a synchronous value as well. That’s whatPromisablefromtype-festdoes.