Repository navigation
Return an error for an out-of-range non-encoded entry instead of panicking - #65
Open
gravenuance wants to merge 1 commit into
Open
gravenuance wants to merge 1 commit into
gravenuance wants to merge 1 commit into
Conversation
…cking A full directory index entry with a negative offset -n refers to non-encoded entry n - 1. The index was used unchecked, so a malformed or truncated pak panicked with "index out of bounds" while reading the index instead of returning an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full directory index entry with a negative offset
-nrefers to non-encoded entryn - 1. That index was used unchecked, so a malformed or truncated pak panics withindex out of boundswhile the index is read, instead of returning an error. This returns a newError::UnknownNonEncodedEntry(index, count)instead.The added test writes a v11 pak, points its one directory-index offset at a non-encoded entry that doesn't exist, and expects the error. It panics without the change.
cargo test --workspacepasses apart fromtest_readme_help, which fails the same way on master on Windows.