Repository navigation
fix: include existing PCB records in PcbCircuitElement - #950
Draft
1932819331hy-debug wants to merge 1 commit into
Draft
1932819331hy-debug wants to merge 1 commit into
1932819331hy-debug wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These existing PCB schemas are already exported and registered in the general circuit-element union, but their parsed records cannot be assigned to PcbCircuitElement. Add the missing type imports/members, following the same kind of correction as #447. No runtime schema changes.
Historical evidence
Only the PCB type barrel and the regression test are changed; no local config, dependency or evidence artifacts are included.
Locked native follow-up (2026-11-16)
The exact unchanged head was restored in a complete checkout and installed with
bun install --frozen-lockfile. The original lockfile remained unchanged; TypeScript 5.8.3 and real ts-expect 1.3.0 now match the locked environment. No stubs, source changes or relaxed compiler settings were used.tsc --noEmit: exit 0.bun test: 516 pass, 0 fail, 2,827 assertions, 1 snapshot, across 197 files. No timeout override or adapted tests.src/pcb/properties/pcb_pin1_location.ts,tests/pcb_board_flex_material.test.ts,tests/pcb_packing_error.test.tsandtests/pcb_pin1_location.test.ts. No unrelated formatting cleanup.The first nested-script invocation could not find Bun on PATH (exit 127); a command-local PATH prefix fixed that. The initial downstream compiler invocation from the outer evidence directory could not resolve Node types; the unchanged consumer compiled from its own directory. Those failed attempts remain recorded, not silently counted as passes.
An independent follow-up verified the exact source/lock state and installed direct versions, reproduced the candidate full compiler pass and the parent's 14 target diagnostics, lint/build and freshly extracted package type/runtime consumers. The rebuilt outputs matched the tarball byte-for-byte. It audited the recorded complete 516-test logs and independently reran the targeted schema regression, rather than claiming a second complete 516-test execution. The four parent-identical formatting failures were independently reproduced.
These results close the earlier local compiler/dependency and native-build gaps, but do not claim hosted approval, all-format-green or Ready. The original type-design review was not repeated.
Merge Danger
Door: Two-way; no migration.
Blast Radius: Type consumers. The union now accepts these already-existing PCB records; downstream exhaustive switches may need to handle them. Runtime parsing is unchanged.
AI-assisted implementation and independent AI-assisted local review.