Skip to content

Added rise filter - #150

Merged
una merged 3 commits into
una:masterfrom
raphaklaus:master
Jan 27, 2016
Merged

una merged 3 commits into
una:masterfrom
raphaklaus:master

Conversation

@raphaklaus

Copy link
Copy Markdown
Contributor

No description provided.

@raphaklaus

Copy link
Copy Markdown
Contributor Author

There's an another pull request for this situation (#140). Feel free to close if necessary. :)

@raphaklaus raphaklaus mentioned this pull request Jan 23, 2016
@una una mentioned this pull request Jan 23, 2016
@raphaklaus

Copy link
Copy Markdown
Contributor Author

Ok! Let me test it to see the diff.

@raphaklaus

Copy link
Copy Markdown
Contributor Author

Looks fine! I've just fixed the radial-gradient without background property, and elevated the saturate value a bit. 😄

@una

una commented Jan 25, 2016

Copy link
Copy Markdown
Owner

I'm not sure it needs so much saturation -- are you checking with the test page at http://localhost:3000/test/?

You first will need to add @import 'rise' to scss/cssgram.scss to get it on the list

@raphaklaus

Copy link
Copy Markdown
Contributor Author

My apologies! I didn't see the test site. Well, I think it's hard to achieve the exact same result of Instagram filter. I've tried with linear and radial gradient together and get pretty decent output. But I don't wanna extend this PR. I'm committing changes as you recommended above.

@una

una commented Jan 27, 2016

Copy link
Copy Markdown
Owner

Yeah you're definitely right -- but this looks great :) thank you for your time!

una added a commit that referenced this pull request Jan 27, 2016
@una
una merged commit 9a50a46 into una:master Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants