Repository navigation
feat(vgplot): Support strict type checking - #1397
Open
dangotbanned wants to merge 9 commits into
Open
dangotbanned wants to merge 9 commits into
dangotbanned wants to merge 9 commits into
Conversation
dangotbanned
marked this pull request as ready for review
November 9, 2026 20:29
dangotbanned
added a commit
that referenced
this pull request
Nov 11, 2026
(#1397) Found 479 errors in 45 files. Not planning on dealing with those now
dangotbanned
force-pushed
the
js-to-ts/vgplot-2-strict
branch
from
November 13, 2026 16:12
0e71ad2 to
ad39386
Compare
dangotbanned
force-pushed
the
js-to-ts/vgplot-2-strict
branch
from
November 16, 2026 21:24
ad39386 to
27f467e
Compare
All four calls reported incompatible signatures
All of the others would have this too, but they also have other errors (#1394 (comment))
IMO this is worse but oh well
dangotbanned
force-pushed
the
js-to-ts/vgplot-2-strict
branch
from
November 16, 2026 21:54
27f467e to
56e1d73
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I got curious about how much work it'd take on top of (#1394) and it turned out mostly painless.