Repository navigation
Conversation
DSH v4 gives producer-owned context its own source kind, so the plugin drops every user-role message whose kind is not user or tool. A host plugin that relays what people wrote (Linear comments, review findings) under its own kind therefore never reaches capture or recall, and OpenViking only extracts memories from user-role messages. inputSourceKinds (OPENVIKING_INPUT_SOURCE_KINDS) lists such kinds. It is empty by default, so behavior is unchanged; the plugin's own injections stay excluded even when listed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The DSH memory plugin treats every user-role message whose
source.kindis notuserortoolas injected context, so it neither captures it nor uses it as a recall query. That is right fortime-context, job notices and other plugins' blocks. It also drops hosts that relay what people wrote under their own kind: a DSH plugin that forwards Linear comments and PR review findings to a worker asdsh-superagentmessages leaves the worker with no user input at all, so recall never fires and OpenViking extracts no memories (it only takes memories from user-role messages).This adds
inputSourceKinds(OPENVIKING_INPUT_SOURCE_KINDS), a list of source kinds whose user-role messages count as genuine input for capture and recall. It is empty by default, so behavior is unchanged.Human Involvement
Related Issue
None.
Type of Change
Changes Made
memory-plugin-shared/lib/config-schema.mjs: new list knobinputSourceKinds(synced into the committed claude-code and codex copies)dsh-memory-plugin/capture.mjs: listed kinds are input forcaptureEventandpromptText; the plugin's own injections stay excluded even when listed, and tool results keep theircaptureToolResultsgatedsh-memory-plugin/runtime.mjs: recall passes the per-session config topromptTextdocs/{en,zh}/agent-integrations/17-dsh.md: document the knobTesting
examples/dsh-memory-plugin:npm testpasses the three new tests. One existing test (a session never inherits the launch workspace's peer id or source) fails in my environment with and without this change.examples/memory-plugin-shared:node --test *.test.mjsshows the same failure set asmain(environment-dependent workspace and desktop-path tests).Checklist