Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
The Docker and E2E workflow runs for this PR were marked failed after remaining pending, with no jobs shown in either run. Could a maintainer check the workflow approval or configuration and advise on running the appropriate PR checks? I can address any results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Problem
On Windows, a fresh clone with
core.autocrlf=truechecks out shell scripts and the version test fixture with CRLF endings. Bash then rejectsscripts/check-version-rule.shat line 26, andgo test ./pkg/versionreads a trailing carriage return fromversion_strings.tsv.Solution
Add
.gitattributesrules that keep tracked*.sh,Dockerfile, andbackend/pkg/version/testdata/version_strings.tsvat LF in the working tree. This changes checkout behavior only; no application logic or fixture values change.Type of Change
Areas Affected
Testing and Verification
Test Configuration
Test Steps and Results
core.autocrlf=true:bash -n scripts/check-version-rule.shfails at line 26, andgo test ./pkg/versionfails because the fixture line ends in\r.git ls-files --eolreportsw/lffor all tracked shell scripts,Dockerfile, and the version fixture.bash -npasses for all 16 tracked shell scripts;go test ./pkg/versionpasses.scripts/check-version-rule.shin a Linuxdocker:clicontainer with Docker socket access. All six label, binary, andversion.shcases pass:check-version-rule: label, binary and version.sh agree on all six.git diff --checkpasses. Broader Windows Go tests inpkg/flowfilesstill fail on existing Unix-path expectations; this change does not touch that package.Security Considerations
No permissions, dependencies, or runtime behavior change. The version check can execute on Windows checkouts with Bash.
Performance Impact
None.
Documentation Updates
None required.
Deployment Notes
No migration or configuration change. Existing worktrees can refresh the affected files with Git; fresh clones get LF automatically.
Checklist